lkml.org 
[lkml]   [2011]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: cx23885-input.c does in fact use a workqueue....
On Sun, Feb 13, 2011 at 08:35:22PM -0500, Andy Walls wrote:
> Tejun,
>
> I just noticed this commit:
>
> commit 8c71778cbf2c8beaefaa2dee5478aa0622d96682
> Author: Tejun Heo <tj@kernel.org>
> Date: Fri Dec 24 16:14:20 2010 +0100
>
> media/video: don't use flush_scheduled_work()
>
> This patch converts the remaining users of flush_scheduled_work() in
> media/video.
>
> * bttv-input.c and cx23885-input.c don't use workqueue at all. No
> need to flush.
> [...]
>
>
> The cx23885 driver does in fact schedule work for IR input handling:
>
> Here's where it is scheduled for CX23888 chips:
>
> http://git.linuxtv.org/media_tree.git?a=blob;f=drivers/media/video/cx23885/cx23885-ir.c;h=7125247dd25558678c823ee3262675570c9aa630;hb=HEAD#l76
>
> Here's where it is scheduled for CX23885 chips:
>
> http://git.linuxtv.org/media_tree.git?a=blob;f=drivers/media/video/cx23885/cx23885-core.c;h=359882419b7f588b7c698dbcfb6a39ddb1603301;hb=HEAD#l1861
>
>
> The two different chips are handled slightly differently because
>
> a. the CX23888 IR unit is accessable via a PCI register block. The IR
> IRQ can be acknowledged with direct PCI register accesses in an
> interrupt context, and the IR pulse FIFO serviced later in a workqueue
> context.
>
> b. the CX23885 IR unit is accessed over an I2C bus. The CX23885 A/V IRQ
> has to be masked in an interrupt context (with PCI registers accesses).
> Then the CX23885 A/V unit's IR IRQ is ack'ed over I2C in a workqueue
> context and the IR pulse FIFO is also serviced over I2C in a workqueue
> context.
>
>
> So what should be done about the flush_scheduled_work()? I think it
> belongs there.
>

Convert to using threaded irq?

--
Dmitry


\
 
 \ /
  Last update: 2011-02-14 05:37    [W:0.082 / U:18.948 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site