lkml.org 
[lkml]   [2011]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2] module: deal with alignment issues in built-in module parameters
    Date
    On Sat, 12 Feb 2011 08:33:56 am Dmitry Torokhov wrote:
    > >From 03f1332fc02af7af0d06ab409e3ec72107637845 Mon Sep 17 00:00:00 2001
    > From: Dmitry Torokhov <dtor@vmware.com>
    > Date: Mon, 7 Feb 2011 13:47:20 -0800
    > Subject: [PATCH] module: deal with alignment issues in built-in module parameters
    >
    > As DaveM said, we can't reliably put structures into independent
    > objects, put them into a special section, and then expect array
    > access over them (via the section boundaries) after linking the
    > objects together to just "work" due to variable alignment choices
    > in different situations. The only solution that seems to work
    > reliably is to make an array of plain pointers to the objects in
    > question and put those pointers in the special section.

    I've applied this, but won't put it to linux-next. I'll let it stew for
    a bit longer unless someone actually reports a problem with the current
    code.

    Thanks,
    Rusty.


    \
     
     \ /
      Last update: 2011-02-14 04:55    [W:0.031 / U:88.784 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site