Messages in this thread | | | From | Marcelo Roberto Jimenez <> | Date | Fri, 11 Feb 2011 10:34:25 -0200 | Subject | Re: [PATCH 1/4] RTC: Include information about UIE and PIE in RTC driver proc. |
| |
Hi John,
On Thu, Feb 10, 2011 at 21:06, John Stultz <john.stultz@linaro.org> wrote: > > This seems to be mostly formatting changes. Are you sure we wont' break > applications expecting the existing format?
No, I can't be 100% sure, that will depend upon how the application parses the proc output. The formatting changes are all white space, so I could remove them. If the value is read using scanf, white spaces are skipped and the "\t" that were added to make the output pleasant to the view are not a problem. That part can be reworked if you think the breakage is serious, it is not really important.
The important thing in the patch are the information additions to the proc interface: update IRQ enabled, periodic IRQ enabled, periodic IRQ frequency and max user IRQ frequency. What do you think about these?
> thanks > -john
Regards, Marcelo.
| |