lkml.org 
[lkml]   [2011]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] cap_syslog: don't refuse cap_sys_admin for now (v3)
On Thu, 10 Feb 2011, Linus Torvalds wrote:

> On Thu, Feb 10, 2011 at 6:40 AM, Serge E. Hallyn <serge@hallyn.com> wrote:
> >
> > Please apply.
>
> Hmm. So I detest the duplication and the ugly resulting code. It was
> a bit hard to follow before, now it's just nasty.
>
> Why not make this all into some nicer helper functions instead -
> something simple like the attached?
>
> UNTESTED! I'm not going to apply it unless I get acks/tested-by's.

Reviewed-by: James Morris <jmorris@namei.org>


--
James Morris
<jmorris@namei.org>


\
 
 \ /
  Last update: 2011-02-11 00:01    [W:0.121 / U:0.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site