Messages in this thread | | | Date | Fri, 11 Feb 2011 09:59:07 +1100 (EST) | From | James Morris <> | Subject | Re: [PATCH 1/1] cap_syslog: don't refuse cap_sys_admin for now (v3) |
| |
On Thu, 10 Feb 2011, Linus Torvalds wrote:
> On Thu, Feb 10, 2011 at 6:40 AM, Serge E. Hallyn <serge@hallyn.com> wrote: > > > > Please apply. > > Hmm. So I detest the duplication and the ugly resulting code. It was > a bit hard to follow before, now it's just nasty. > > Why not make this all into some nicer helper functions instead - > something simple like the attached? > > UNTESTED! I'm not going to apply it unless I get acks/tested-by's.
Reviewed-by: James Morris <jmorris@namei.org>
-- James Morris <jmorris@namei.org>
| |