[lkml]   [2011]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 5/5] have smaps show transparent huge pages
    On Thu, 2011-02-10 at 19:09 +0100, Andrea Arcangeli wrote:
    > Maybe it'd be cleaner if we didn't need to cast the pmd to pte_t but I
    > guess this makes things simpler.

    Yeah, I'm not a huge fan of doing that, either. But, I'm not sure what
    the alternatives are. We could basically copy smaps_pte_entry() to
    smaps_pmd_entry(), and then try to make pmd variants of all of the pte
    functions and macros we call in there.

    I know there's a least a bit of precedent in the hugetlbfs code for
    doing things like this, but it's not a _great_ excuse. :)

    -- Dave

     \ /
      Last update: 2011-02-10 19:23    [W:0.020 / U:5.640 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site