Messages in this thread | | | From | "Henrik Rydberg" <> | Date | Thu, 10 Feb 2011 14:18:16 +0100 | Subject | Re: [PATCH 1/1] Fix error path in wacom_probe |
| |
Hi Alexander,
> In file drivers/input/tablet/wacom_sys.c in > wacom_probe after error we can goto label2. In > this case function usb_free was not called. > It will be right goto for the label tail3. > > wacom->irq = usb_alloc_urb(0, GFP_KERNEL); > > ... > > /* Retrieve the physical and logical size for OEM devices */ > error = wacom_retrieve_hid_descriptor(intf, features); > if (error) > goto fail2; > ... > fail3: usb_free_urb(wacom->irq); > fail2: usb_free_coherent(dev, WACOM_PKGLEN_MAX, wacom_wac->data, wacom->data_dma); > > Replaced wrong transition.
Yep, thanks for this.
Acked-by: Henrik Rydberg <rydberg@euromail.se>
| |