Messages in this thread | | | From | Eric Miao <> | Date | Thu, 10 Feb 2011 20:40:54 +0800 | Subject | Re: [RFC v2 PATCH 1/7] matrix_keypad: Increase the max limit of rows and columns |
| |
On Thu, Feb 10, 2011 at 8:20 PM, Trilok Soni <tsoni@codeaurora.org> wrote: > Hi Dmitry, > > On 2/9/2011 1:32 PM, Eric Miao wrote: >> On Tue, Feb 1, 2011 at 9:47 PM, Anirudh Ghayal <aghayal@codeaurora.org> wrote: >>> From: Trilok Soni <tsoni@codeaurora.org> >>> >>> Some keyboard controller have support for more than >>> 16 columns and rows. Moving this value to 32. >>> >>> Cc: Eric Miao <eric.y.miao@gmail.com> >>> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> >>> Signed-off-by: Trilok Soni <tsoni@codeaurora.org> >> >> This looks good to me, as long as the bits don't exceed 256, which >> is used in the #KEY() macro. So far, 32 looks to be a sane number >> to me, unless we have further requirement to get this larger. >> >> Acked-by: Eric Miao <eric.y.miao@gmail.com> >> > > Are you going to pick up this patch only from the series you want us to get > it submitted it separately?
I believe Dmitry will pick this series once all the patches are reviewed?
| |