lkml.org 
[lkml]   [2011]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Patch 0/4] Fix error handling in hfsplus mount failure paths
On Tue, Feb 01, 2011 at 04:28:02PM -0500, Chuck Ebbert wrote:
> hfsplus can generate NULL pointer exceptions when a user attempts
> to mount an invalid filesystem. In some paths it also leaks memory.
>
> This series attempts to fix some of the most obvious problems.

Not in a very nice way, though. The real problem here is that we

a) can still return a failure after sb->s_root is set
b) abuse hfsplus_put_super for error handling, which is totally
ill-suited.

Take a look at the patch in
https://bugzilla.kernel.org/show_bug.cgi?id=27932 for a proper fix.


\
 
 \ /
  Last update: 2011-02-01 23:11    [W:0.040 / U:56.528 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site