lkml.org 
[lkml]   [2011]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 08/28] posix-timers: Cleanup restart_block usage
On Tue, 1 Feb 2011, john stultz wrote:
> On Tue, 2011-02-01 at 13:51 +0000, Thomas Gleixner wrote:
> > - restart_block->fn = posix_cpu_nsleep_restart;
> > - restart_block->arg0 = which_clock;
> > - restart_block->arg1 = (unsigned long) rmtp;
> > - restart_block->arg2 = t.tv_sec;
> > - restart_block->arg3 = t.tv_nsec;
> > + restart_block->nanosleep.expires = timespec_to_ns(&t);
>
> The conversion back and forth from nanoseconds to timespec seems a
> little extraneous, but short of reworking all of the do_nanosleep calls
> to take a ktime I don't see a clean solution (since hrtimer also uses
> the restart_block).

We could simply add a timespec to the nanosleep struct in the
restart_block. Could be a union with expires.

Thanks,

tglx


\
 
 \ /
  Last update: 2011-02-01 22:17    [W:0.124 / U:1.648 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site