lkml.org 
[lkml]   [2011]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] NX protection for kernel data : fix 32 bits S3 suspend
On 02/01/2011 05:25 AM, castet.matthieu@free.fr wrote:
>
> The proper fix will be done in 2.6.29, when S3 resume 32 bit trampoline will be
> merged with 64 bit (ie call smp trampoline) [1]
>

That's insufficient; the actual unified lowmem trampoline allocator
should take care of that bit per se.

However, the bottom line seems to be that this patch was done with some
extreme lack of care. To really be proper, every allocation from the
get go -- including the brk and memblock based ones -- should be tagged
with their execution status, and that information should be used, not
some magic ranges.

-hpa


\
 
 \ /
  Last update: 2011-02-01 17:33    [W:0.077 / U:6.580 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site