lkml.org 
[lkml]   [2011]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] hrtimers: Add CLOCK_BOOTTIME clockid, hrtimerbase and posix interface
On Mon, 31 Jan 2011, John Stultz wrote:

> CLOCK_MONOTONIC stops while the system is in suspend. This is because
> to applications system suspend is invisible. However, there is a
> growing set of applications that are wanting to be suspend-aware,
> but do not want to deal with the complicatoins of CLOCK_REALTIME
> (which might jump around if settimeofday is called).
>
> For these applications, I propose a new clockid: CLOCK_BOOTTIME.
> CLOCK_BOOTTIME is idential to CLOCK_MONOTONIC, except it also
> includes any time spent in suspend.
>
> This patch adds the new CLOCK_BOOTTIME clockid, as well as the
> infrastructure needed to support hrtimers against it, and the
> wiring to expose it out via the posix interface.

Can you please split that into parts:

- Add the new functions
- Wire up hrtimers, posix-timers

> static void hrtimer_get_softirq_time(struct hrtimer_cpu_base *base)
> {
> - ktime_t xtim, tomono;
> - struct timespec xts, tom;
> + ktime_t xtim, tomono, sleep;
> + struct timespec xts, tom, slp;
> unsigned long seq;
>
> do {
> seq = read_seqbegin(&xtime_lock);
> xts = __current_kernel_time();
> tom = __get_wall_to_monotonic();
> + slp = __get_sleep_time();
> } while (read_seqretry(&xtime_lock, seq));

Hmm, that conflicts with the xtime_lock cleanup in tip/timers/core.

> /*
> * Initialize everything, well, just everything in Posix clocks/timers ;)
> */
> @@ -301,12 +309,18 @@ static __init int init_posix_timers(void)
> .timer_create = no_timer_create,
> .nsleep = no_nsleep,
> };
> + struct k_clock clock_boottime = {
> + .clock_getres = hrtimer_get_res,
> + .clock_get = posix_get_boottime,
> + .clock_set = do_posix_clock_nosettime,

That's going to conflict with the posix timer cleanup, but it's easy enough to fix.

Thanks,

tglx


\
 
 \ /
  Last update: 2011-02-01 15:19    [W:0.049 / U:13.416 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site