lkml.org 
[lkml]   [2011]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] ptrace: use safer wake up on ptrace_detach()
    On 02/01, Tejun Heo wrote:
    >
    > --- work.orig/kernel/ptrace.c
    > +++ work/kernel/ptrace.c
    > @@ -313,7 +313,7 @@ int ptrace_detach(struct task_struct *ch
    > child->exit_code = data;
    > dead = __ptrace_detach(current, child);
    > if (!child->exit_state)
    > - wake_up_process(child);
    > + wake_up_state(child, TASK_TRACED | TASK_STOPPED);

    Well, it can't be TASK_TRACED at this point. And of course this still
    contradicts to __set_task_state(child, TASK_STOPPED) in ptrace_untrace().
    IOW, to me the previous patch makes more sense.

    But OK, I understand Roland's concerns. And, at least this change
    fixes the bug mentioned in 95a3540d.

    Acked-by: Oleg Nesterov <oleg@redhat.com>



    \
     
     \ /
      Last update: 2011-02-01 14:51    [W:0.018 / U:66.052 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site