lkml.org 
[lkml]   [2011]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging: tm6000: fixed some coding style issues
Hi Timo,

On Tue, 1 Feb 2011 12:22:21 +0100, Timo von Holtz wrote:
> Fixed all of the following coding style issues:
>
> ERROR: return is not a function, parentheses are not required
> WARNING: __func__ should be used instead of gcc specific __FUNCTION__

You messed up and replaced with __func instead of __func__.

> ERROR: trailing whitespace
> ERROR: spaces required around that '=' (ctx:VxV)
> WARNING: please, no space before tabs
> WARNING: please, no spaces at the start of a line
> ERROR: space required after that ',' (ctx:VxV)
> WARNING: space prohibited between function name and open parenthesis '('
> ERROR: spaces required around that '<' (ctx:VxV)
> ERROR: spaces required around that '==' (ctx:VxV)
>
> Signed-off-by: Timo von Holtz <tvh@informatik.uni-kiel.de>
> ---
> drivers/staging/tm6000/tm6000-alsa.c | 6 +++---
> drivers/staging/tm6000/tm6000-core.c | 4 ++--
> drivers/staging/tm6000/tm6000-dvb.c | 10 +++++-----
> drivers/staging/tm6000/tm6000-i2c.c | 2 +-
> drivers/staging/tm6000/tm6000-regs.h | 2 +-
> drivers/staging/tm6000/tm6000-usb-isoc.h | 2 +-
> drivers/staging/tm6000/tm6000-video.c | 28 ++++++++++++++--------------
> drivers/staging/tm6000/tm6000.h | 4 ++--
> 8 files changed, 29 insertions(+), 29 deletions(-)
> (...)
> --- a/drivers/staging/tm6000/tm6000-usb-isoc.h
> +++ b/drivers/staging/tm6000/tm6000-usb-isoc.h
> @@ -46,5 +46,5 @@ struct usb_isoc_ctl {
> int tmp_buf_len;
>
> /* Stores already requested buffers */
> - struct tm6000_buffer *buf;
> + struct tm6000_buffer *buf;

You want one more tab to keep the struct elements aligned.

Other than that, this patch looks mostly good.

--
Jean Delvare


\
 
 \ /
  Last update: 2011-02-01 13:27    [W:0.028 / U:1.752 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site