lkml.org 
[lkml]   [2011]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v8 1/9] Basic kernel memory functionality for the Memory Controller
    On 12/08/2011 11:21 PM, KAMEZAWA Hiroyuki wrote:
    > Hm, why you check val != parent->kmem_independent_accounting ?
    >
    > if (parent&& parent->use_hierarchy)
    > return -EINVAL;
    > ?
    >
    > BTW, you didn't check this cgroup has children or not.
    > I think
    >
    > if (this_cgroup->use_hierarchy&&
    > !list_empty(this_cgroup->childlen))
    > return -EINVAL;

    How about this?

    val = !!val;

    /*
    * This follows the same hierarchy restrictions than
    * mem_cgroup_hierarchy_write()
    */
    if (!parent || !parent->use_hierarchy) {
    if (list_empty(&cgroup->children))
    memcg->kmem_independent_accounting = val;
    else
    return -EBUSY;
    }
    else
    return -EINVAL;

    return 0;



    \
     
     \ /
      Last update: 2011-12-09 15:41    [W:0.025 / U:121.464 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site