lkml.org 
[lkml]   [2011]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH v6 10/10] arm/tegra: add support for tegra30 based board cardhu
    On 12/08/2011 06:43 AM, Peter De Schrijver wrote:
    > Add support for the tegra30 based cardhu development board. Cardhu is a tablet
    > formfactor reference design for tegra30. The patch provides a device tree for
    > the board, updates Makefile.boot to build the dtb, includes the platform in
    > Kconfig and updates board-dt.c.
    >
    > Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
    > ---
    > arch/arm/boot/dts/tegra-cardhu.dts | 36 ++++++++++++++++++++++++++++++++++++
    > arch/arm/mach-tegra/Kconfig | 7 +++++++
    > arch/arm/mach-tegra/Makefile.boot | 1 +
    > arch/arm/mach-tegra/board-dt.c | 1 +
    > 4 files changed, 45 insertions(+), 0 deletions(-)
    > create mode 100644 arch/arm/boot/dts/tegra-cardhu.dts
    >
    > diff --git a/arch/arm/boot/dts/tegra-cardhu.dts b/arch/arm/boot/dts/tegra-cardhu.dts
    > new file mode 100644
    > index 0000000..70c41fc
    > --- /dev/null
    > +++ b/arch/arm/boot/dts/tegra-cardhu.dts
    > @@ -0,0 +1,36 @@
    > +/dts-v1/;
    > +
    > +/include/ "tegra30.dtsi"
    > +
    > +/ {
    > + model = "NVIDIA Tegra30 Cardhu evaluation board";
    > + compatible = "nvidia,cardhu", "nvidia,tegra30";
    > +
    > + memory {

    memory@80000000

    > + reg = < 0x80000000 0x40000000 >;
    > + };
    > +
    > + serial@70006000 {
    > + clock-frequency = < 408000000 >;
    > + };
    > +
    > + i2c@7000c000 {
    > + clock-frequency = <100000>;
    > + };
    > +
    > + i2c@7000c400 {
    > + clock-frequency = <100000>;
    > + };
    > +
    > + i2c@7000c500 {
    > + clock-frequency = <100000>;
    > + };
    > +
    > + i2c@7000c700 {
    > + clock-frequency = <100000>;
    > + };
    > +
    > + i2c@7000d000 {
    > + clock-frequency = <100000>;
    > + };
    > +};
    > diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig
    > index aad54ca..6bae1bb 100644
    > --- a/arch/arm/mach-tegra/Kconfig
    > +++ b/arch/arm/mach-tegra/Kconfig
    > @@ -91,6 +91,13 @@ config MACH_VENTANA
    > help
    > Support for the nVidia Ventana development platform
    >
    > +config MACH_CARDHU
    > + bool "Cardhu board"
    > + depends on ARCH_TEGRA_3x_SOC
    > + select MACH_TEGRA_DT
    > + help
    > + Support for the NVIDIA Cardhu development platform
    > +

    You should not be adding kconfig entries for boards. They should
    eventually go away with DT.

    > choice
    > prompt "Low-level debug console UART"
    > default TEGRA_DEBUG_UART_NONE
    > diff --git a/arch/arm/mach-tegra/Makefile.boot b/arch/arm/mach-tegra/Makefile.boot
    > index cf51a00..7c1110f 100644
    > --- a/arch/arm/mach-tegra/Makefile.boot
    > +++ b/arch/arm/mach-tegra/Makefile.boot
    > @@ -7,3 +7,4 @@ dtb-$(CONFIG_MACH_PAZ00) += tegra-paz00.dtb
    > dtb-$(CONFIG_MACH_SEABOARD) += tegra-seaboard.dtb
    > dtb-$(CONFIG_MACH_TRIMSLICE) += tegra-trimslice.dtb
    > dtb-$(CONFIG_MACH_VENTANA) += tegra-ventana.dtb
    > +dtb-$(CONFIG_MACH_CARDHU) += tegra-cardhu.dtb

    Likewise, this should be more like:
    dtb-$(CONFIG_MACH_TEGRA_DT) += tegra-seaboard.dtb tegra-trimslice.dtb
    tegra-ventana.dtb ...

    Rob
    > diff --git a/arch/arm/mach-tegra/board-dt.c b/arch/arm/mach-tegra/board-dt.c
    > index d1ed473..14ef047 100644
    > --- a/arch/arm/mach-tegra/board-dt.c
    > +++ b/arch/arm/mach-tegra/board-dt.c
    > @@ -157,6 +157,7 @@ MACHINE_END
    >
    > #ifdef CONFIG_ARCH_TEGRA_3x_SOC
    > static const char *tegra30_dt_board_compat[] = {
    > + "nvidia,cardhu",
    > NULL
    > };
    >


    \
     
     \ /
      Last update: 2011-12-09 15:33    [W:0.028 / U:33.252 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site