Messages in this thread | | | Date | Fri, 9 Dec 2011 20:24:59 +0800 | From | Mark Brown <> | Subject | Re: [PATCH v3] sound/soc/lapis: add machine driver v3 updated |
| |
On Fri, Dec 09, 2011 at 08:03:52PM +0900, Tomoya MORINAGA wrote:
> + snd_soc_dapm_new_controls(dapm, ml7213_dapm_widgets, > + ARRAY_SIZE(ml7213_dapm_widgets)); > + > + snd_soc_dapm_add_routes(dapm, ml7213_routes, ARRAY_SIZE(ml7213_routes));
You should also use table based init for these (see the card struct). Otherwise this looks good, though obviously there's a dependency on the CPU drivers.
| |