lkml.org 
[lkml]   [2011]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 5/8] net/fec: don't munge MAC address from platform data
    Date
    When the MAC address is supplied via platform_data it should be OK as
    it is and should not be modified in case of a dual FEC setup.
    Also copying the MAC from platform_data to the single 'macaddr'
    variable will overwrite the MAC for the first interface in case of a
    dual FEC setup.

    Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
    Acked-by: Shawn Guo <shawn.guo@linaro.org>
    ---
    drivers/net/ethernet/freescale/fec.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/net/ethernet/freescale/fec.c b/drivers/net/ethernet/freescale/fec.c
    index e2b5ce6..11534b9 100644
    --- a/drivers/net/ethernet/freescale/fec.c
    +++ b/drivers/net/ethernet/freescale/fec.c
    @@ -818,7 +818,7 @@ static void __inline__ fec_get_mac(struct net_device *ndev)
    iap = (unsigned char *)FEC_FLASHMAC;
    #else
    if (pdata)
    - memcpy(iap, pdata->mac, ETH_ALEN);
    + iap = (unsigned char *)&pdata->mac;
    #endif
    }

    --
    1.5.6.5
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-12-08 09:03    [W:0.021 / U:30.268 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site