lkml.org 
[lkml]   [2011]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] hwmon: jz4740: fix signedness bug
    On 12/08/2011 02:04 PM, Axel Lin wrote:
    > wait_for_completion_interruptible_timeout() may return negative value.
    > In this case, checking if (t > 0) will return true if t is unsigned.
    >
    > Signed-off-by: Axel Lin <axel.lin@gmail.com>
    Acked-by: Lars-Peter Clausen <lars@metafoo.de>

    Thanks

    > ---
    > drivers/hwmon/jz4740-hwmon.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/drivers/hwmon/jz4740-hwmon.c b/drivers/hwmon/jz4740-hwmon.c
    > index 7a48b1e..3d7e590 100644
    > --- a/drivers/hwmon/jz4740-hwmon.c
    > +++ b/drivers/hwmon/jz4740-hwmon.c
    > @@ -59,7 +59,7 @@ static ssize_t jz4740_hwmon_read_adcin(struct device *dev,
    > {
    > struct jz4740_hwmon *hwmon = dev_get_drvdata(dev);
    > struct completion *completion = &hwmon->read_completion;
    > - unsigned long t;
    > + long t;
    > unsigned long val;
    > int ret;
    >



    \
     
     \ /
      Last update: 2011-12-08 15:11    [W:0.023 / U:89.264 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site