[lkml]   [2011]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[011/104] drm/i915: Fix inconsistent backlight level during disabled
3.1-stable review patch.  If anyone has any objections, please let me know.


From: Takashi Iwai <>

commit 04b38670cf46c096705f24e92a8747d1ab89e53c upstream.

When the brightness property is inquired while the backlight is disabled,
the driver returns a wrong value (zero) because it probes the value after
the backlight was turned off. This caused a black screen even after the
backlight is enabled again. It should return the internal backlight_level
instead, so that it won't be influenced by the backlight-enable state.


Tested-by: Kamal Mostafa <>
Cc: Alex Davis <>
Signed-off-by: Takashi Iwai <>
Signed-off-by: Keith Packard <>
Signed-off-by: Greg Kroah-Hartman <>

drivers/gpu/drm/i915/intel_panel.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

--- a/drivers/gpu/drm/i915/intel_panel.c
+++ b/drivers/gpu/drm/i915/intel_panel.c
@@ -326,7 +326,8 @@ static int intel_panel_update_status(str
static int intel_panel_get_brightness(struct backlight_device *bd)
struct drm_device *dev = bl_get_data(bd);
- return intel_panel_get_backlight(dev);
+ struct drm_i915_private *dev_priv = dev->dev_private;
+ return dev_priv->backlight_level;

static const struct backlight_ops intel_panel_bl_ops = {

 \ /
  Last update: 2011-12-07 17:53    [W:0.238 / U:3.008 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site