lkml.org 
[lkml]   [2011]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[38/80] SCSI: Silencing killing requests for dead queue
    3.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Hannes Reinecke <hare@suse.de>

    commit 745718132c3c7cac98a622b610e239dcd5217f71 upstream.

    When we tear down a device we try to flush all outstanding
    commands in scsi_free_queue(). However the check in
    scsi_request_fn() is imperfect as it only signals that
    we _might start_ aborting commands, not that we've actually
    aborted some.
    So move the printk inside the scsi_kill_request function,
    this will also give us a hint about which commands are aborted.

    Signed-off-by: Hannes Reinecke <hare@suse.de>
    Signed-off-by: James Bottomley <JBottomley@Parallels.com>
    Cc: Christoph Biedl <linux-kernel.bfrz@manchmal.in-ulm.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/scsi/scsi_lib.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/scsi/scsi_lib.c
    +++ b/drivers/scsi/scsi_lib.c
    @@ -1407,6 +1407,8 @@ static void scsi_kill_request(struct req

    blk_start_request(req);

    + scmd_printk(KERN_INFO, cmd, "killing request\n");
    +
    sdev = cmd->device;
    starget = scsi_target(sdev);
    shost = sdev->host;
    @@ -1488,7 +1490,6 @@ static void scsi_request_fn(struct reque
    struct request *req;

    if (!sdev) {
    - printk("scsi: killing requests for dead queue\n");
    while ((req = blk_peek_request(q)) != NULL)
    scsi_kill_request(req, q);
    return;



    \
     
     \ /
      Last update: 2011-12-07 17:21    [W:0.018 / U:38.044 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site