lkml.org 
[lkml]   [2011]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] Revert "ARM: RX-51: Enable isp1704 power on/off"
    On 12/05/2011 07:31 PM, Felipe Contreras wrote:
    > Should probably have CC'ed linux-omap.
    >
    > On Mon, Dec 5, 2011 at 7:23 PM, Felipe Contreras
    > <felipe.contreras@nokia.com> wrote:
    >> From: Felipe Contreras<felipe.contreras@gmail.com>
    >>
    >> This reverts commit 10299e2e4e3ed3b16503d4e04edd48b33083f4e2.
    >>
    >> This seems to break USB networking stuff.
    >>
    I don't think revert is needed since CONFIG_CHARGER_ISP1704=y should
    make it working. Although I don't know do we really need to drive the
    ISP1704 into reset in board-rx51-peripherals.c? Would it be better to
    leave gpio state as it was set by the bootloader and let the driver to
    do reset sequence if needed?

    http://marc.info/?l=linux-omap&m=130795363204884&w=2

    --
    Jarkko


    \
     
     \ /
      Last update: 2011-12-07 12:49    [W:0.026 / U:2.280 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site