Messages in this thread | | | Subject | RE: [PATCH 1/2] [media] V4L: atmel-isi: add code to enable/disableISI_MCK clock | Date | Wed, 7 Dec 2011 18:12:52 +0800 | From | "Wu, Josh" <> |
| |
Hi, Russell King
On Wed, Dec 07, 2011 at 4:50 PM, Russell King wrote:
> On Wed, Nov 30, 2011 at 06:06:43PM +0800, Josh Wu wrote: >> + /* Get ISI_MCK, provided by programmable clock or external clock */ >> + isi->mck = clk_get(dev, "isi_mck"); >> + if (IS_ERR_OR_NULL(isi->mck)) {
> This should be IS_ERR()
So it means the clk_get() will never return NULL even when clk structure is NULL in clk lookup entry. Right?
>> + dev_err(dev, "Failed to get isi_mck\n"); >> + ret = isi->mck ? PTR_ERR(isi->mck) : -EINVAL;
> ret = PTR_ERR(isi->mck);
Best Regards, Josh Wu
| |