lkml.org 
[lkml]   [2011]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [git pull] apparmor fix for __d_path() misuse
    On Tue, Dec 6, 2011 at 4:39 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
    >
    > IOW, I mean this:

    Yeah, no.

    > +       if (ancestor) {
    > +               ancestor->mnt = mntget(vfsmnt);
    > +               ancestor->dentry = dget(dentry);
    > +       }

    This part is still just pure and utter sh*t.

    You have not explained why that information is *ever* valid. And I
    claim it isn't.

    We have a bug in our current __d_path(). And I claim that the
    underlying cause of the bug is the crazy "let's return this
    nonsensical and idiotic information that cannot possibly make sense to
    anybody".

    We shouldn't have done that in the first place. And we certainly
    shouldn't *continue* doing that.

    Linus
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-12-07 01:45    [W:0.022 / U:32.276 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site