Messages in this thread | | | Date | Tue, 6 Dec 2011 08:33:28 +0100 | From | Lothar Waßmann <> | Subject | Re: [RFC PATCH 2/3] pinctrl: imx: add pinmux-imx53 support |
| |
Hi,
Shawn Guo writes: > On Mon, Dec 05, 2011 at 10:18:38PM +0100, Sascha Hauer wrote: > > Freescale has named the pins after their primary function which is quite > > confusing. > > > > The above means: > > > > MX53_PATA_DATA8 -> mux mode 4 > > MX53_PATA_DATA9 -> mux mode 4 > > ... > > > > This brings me to the point that currently we have the pins described as > > > > #define MX53_PAD_<name>__<function> > > > But that's also the reason why we have so many lengthy iomux-mx*.h on > imx. Taking iomux-mx53.h for example, it's a 109K header with 1219 > LOC, but probably only 10% of the definitions will actually be used. > Which has the benefit of having correct pin definitions for everyone to use. If developers who need to use currently unused pindefs have to create them on their own, there will always be a good chance in getting them wrong.
> > which means that you don't have to look into the datasheet to get the > > different options for a pin > > Looking at the datasheet when we write code is a pretty natural thing > to me. > The pindefs are like interrupt numbers or IO addresses for which there also is a complete list of definitions in the kernel no matter whether they are actually all in use.
Lothar Waßmann -- ___________________________________________________________
Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info@karo-electronics.de ___________________________________________________________ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |