lkml.org 
[lkml]   [2011]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/2] of/irq: Get rid of NO_IRQ usage
    On Tue, Dec 6, 2011 at 1:22 PM, Rob Herring <robherring2@gmail.com> wrote:
    >
    > This warning code is really ugly. Can we just drop it? In my searching
    > of in kernel dts files, there's only 1 instance I have found (Versatile
    > AB watchdog) that would hit this.

    I do agree. Especially since we never got any input on whether it works or not.

    > If not, you don't need to handle irq_create_of_mapping return as that is
    > already always 0 for no irq or error.

    Yeah, I'd like to just remove NO_IRQ from the OF paths. Afaik, it
    hasn't worked as NO_IRQ before anyway, so even if the rest of the
    drivers end up continuing using NO_IRQ, the OF-enabled ones on ARM
    should just stop. There can't be many of those yet.

    Linus


    \
     
     \ /
      Last update: 2011-12-06 22:27    [W:0.028 / U:0.060 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site