Messages in this thread |  | | Date | Tue, 6 Dec 2011 11:26:03 -0800 | | Subject | Re: [PATCH] x86/mcheck/therm_throt.c: Don't log power limit and package level thermal throttle event in mce log | | From | Tony Luck <> |
| |
On Tue, Dec 6, 2011 at 11:06 AM, Borislav Petkov <bp@amd64.org> wrote: > I can see all that. Still, I'm questioning the need for those printks. A > user application polling the counters is a much better solution, IMHO, > than spamming the logs. IOW, is there a strong reason to have this - > even ratelimited - information in the logs and unnerve users, or, would > it be better to collect this info somewhere queitly and present it only > when something requests it?
Striking the right balance here is hard - if one has a BIOS that set the thresholds at "interesting" values - then you certainly don't want to the console to be spammed with a lot of useless junk.
But if there is a real problem - then having someone tell you later that you should have been checking some obscure file in /sys to see that some thermal/power limit events were being seen may not go over very well.
When we have some comprehensive system health monitoring daemon that does check these files, and can be configured to raise suitable alerts, then the printks can go away.
-Tony
|  |