lkml.org 
[lkml]   [2011]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [MXS MMC 4/5] Check the return codes of clk_enable() and mxs_reset_block()
    On Tue, Dec 06, 2011 at 02:41:29PM +0100, Lothar Waßmann wrote:
    > Add an int return value to mxs_mmc_reset(), so that the return code of
    > mxs_reset_block() can be promoted to the caller.
    > Also check the return code of clk_enable() in the probe function.
    >
    > Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
    > - clk_enable(host->clk);
    > + ret = clk_enable(host->clk);
    > + if (ret) {
    > + dev_err(mmc_dev(host->mmc),
    > + "%s: failed to enable clock: %d\n", __func__, ret);
    > + goto out_clk_put;
    > + }
    >
    > - mxs_mmc_reset(host);
    > + ret = mxs_mmc_reset(host);
    > + if (ret) {
    > + dev_err(mmc_dev(host->mmc),
    > + "%s: failed to reset controller: %d\n", __func__, ret);
    > + goto out_clk_put;
    > + }

    Why __func__ here? dev_err and the msg itself should be indication enough?

    Otherwise

    Acked-by: Wolfram Sang <w.sang@pengutronix.de>

    --
    Pengutronix e.K. | Wolfram Sang |
    Industrial Linux Solutions | http://www.pengutronix.de/ |
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2011-12-06 20:15    [W:0.022 / U:34.372 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site