lkml.org 
[lkml]   [2011]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [tip:core/locking] lockdep, bug: Exclude TAINT_FIRMWARE_WORKAROUND from disabling lockdep
From
Date
On Tue, 2011-12-06 at 10:13 -0500, Nick Bowler wrote:
> On 2011-12-06 01:38 -0800, tip-bot for Peter Zijlstra wrote:
> > Commit-ID: df754e6af2f237a6c020c0daff55a1a609338e31
> > Gitweb: http://git.kernel.org/tip/df754e6af2f237a6c020c0daff55a1a609338e31
> > Author: Peter Zijlstra <a.p.zijlstra@chello.nl>
> > AuthorDate: Mon, 14 Nov 2011 13:13:49 +0100
> > Committer: Ingo Molnar <mingo@elte.hu>
> > CommitDate: Tue, 6 Dec 2011 08:16:47 +0100
> >
> > lockdep, bug: Exclude TAINT_FIRMWARE_WORKAROUND from disabling lockdep
> >
> > It's unlikely that TAINT_FIRMWARE_WORKAROUND causes false
> > lockdep messages, so do not disable lockdep in that case.
> > We still want to keep lockdep disabled in the
> > TAINT_OOT_MODULE case:
> >
> > - bin-only modules can cause various instabilities in
> > their and in unrelated kernel code
> >
> > - they are impossible to debug for kernel developers
> >
> > - they also typically do not have the copyright license
> > permission to link to the GPL-ed lockdep code.
>
> This is all bogus. We have a proprietary module taint for the above.
> Out of tree does not mean "bin-only", "non-GPL" or anything else like
> that. If the intent is to tell out of tree, GPL module developers to
> fuck off and die, then just go all the way and delete support for out
> of tree modules from Kbuild. May as well go further and just prevent
> the kernel from loading such modules outright, too.
>
> Don't gag developers by arbitrarily disabling kernel debugging
> functionality: functionality that they can use to debug their
> *GPL* modules.

I totally agree; *I* wanted to keep lockdep enabled for (GPL-compatible)
OOT modules.

Ben.

--
Ben Hutchings
Absolutum obsoletum. (If it works, it's out of date.) - Stafford Beer
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2011-12-06 16:33    [W:1.090 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site