lkml.org 
[lkml]   [2011]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 7/9] readahead: add vfs/readahead tracing event
    > +	TP_printk("readahead-%s(dev=%d:%d, ino=%lu, "

    please don't duplicate the tracepoint name in the output string.
    Also don't use braces, as it jsut complicates parsing.

    > + "req=%lu+%lu, ra=%lu+%d-%d, async=%d) = %d",
    > + ra_pattern_names[__entry->pattern],

    Instead of doing a manual array lookup please use __print_symbolic so
    that users of the binary interface (like trace-cmd) also get the
    right output.

    > --- linux-next.orig/mm/readahead.c 2011-11-29 20:58:53.000000000 +0800
    > +++ linux-next/mm/readahead.c 2011-11-29 20:59:20.000000000 +0800
    > @@ -29,6 +29,9 @@ static const char * const ra_pattern_nam
    > [RA_PATTERN_ALL] = "all",
    > };
    >
    > +#define CREATE_TRACE_POINTS
    > +#include <trace/events/vfs.h>

    Maybe we should create a new fs/trace.c just for this instead of stickin
    it into the first file that created a tracepoint in the "vfs" namespace.



    \
     
     \ /
      Last update: 2011-12-06 16:33    [W:2.380 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site