Messages in this thread | | | Date | Tue, 6 Dec 2011 11:29:59 -0200 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 03/10] perf tools: Continue processing header on unknown features |
| |
Em Tue, Dec 06, 2011 at 11:32:33AM +0100, Robert Richter escreveu: > A feature may be unknown if perf.data is created and parsed on > different perf tool versions. This should not stop the header to be > processed, instead continue processing it.
Ok with me.
> Signed-off-by: Robert Richter <robert.richter@amd.com> > --- > tools/perf/util/header.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c > index bcd05d0..95c3ab1 100644 > --- a/tools/perf/util/header.c > +++ b/tools/perf/util/header.c > @@ -1105,7 +1105,7 @@ static int perf_file_section__fprintf_info(struct perf_file_section *section, > } > if (feat < HEADER_TRACE_INFO || feat >= HEADER_LAST_FEATURE) { > pr_warning("unknown feature %d\n", feat); > - return -1; > + return 0; > } > if (!feat_ops[feat].print) > return 0; > -- > 1.7.7 >
| |