lkml.org 
[lkml]   [2011]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH][NET] several cleanups and bugfixes for fec.c: don't munge MAC address from platform data
    Hi Lothar,

    On Tue, Dec 06, 2011 at 11:27:13AM +0100, Lothar Waßmann wrote:
    > When the MAC address is supplied via platform_data it should be OK as
    > it is and should not be modified in case of a dual FEC setup.
    > Also copying the MAC from platform_data to the single 'macaddr'
    > variable will overwrite the MAC for the first interface in case of a
    > dual FEC setup.
    >
    > Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
    > ---
    > drivers/net/ethernet/freescale/fec.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/drivers/net/ethernet/freescale/fec.c b/drivers/net/ethernet/freescale/fec.c
    > index e2b5ce6..11534b9 100644
    > --- a/drivers/net/ethernet/freescale/fec.c
    > +++ b/drivers/net/ethernet/freescale/fec.c
    > @@ -818,7 +818,7 @@ static void __inline__ fec_get_mac(struct net_device *ndev)
    > iap = (unsigned char *)FEC_FLASHMAC;
    > #else
    > if (pdata)
    > - memcpy(iap, pdata->mac, ETH_ALEN);
    > + iap = (unsigned char *)&pdata->mac;

    Since pdata might point to __initdata struct, you must hold a copy of its
    content.

    baruch

    > #endif
    > }
    >
    > --

    --
    ~. .~ Tk Open Systems
    =}------------------------------------------------ooO--U--Ooo------------{=
    - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-12-06 13:51    [W:0.025 / U:147.664 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site