lkml.org 
[lkml]   [2011]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mfd: add bq2415x charger driver
Hi,

Good to hear somebody is working on this :) I planned to do this
myself, but didn't find any time for it. Here are some comments
from me:

[...]

> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig

I would expect the driver in drivers/power. But maybe MFD is
better, since the chip can also be used to power USB host?

[...]

> +#define BQ2415X_VOLTAGE_SCALE 20000

If I remember correctly (I read the specs some time ago), this can
be configured via external resistor. So this is board specific?

[...]

> + bq2415x_i2c_write(cli, BQ2415X_CHG_CTL, 0x42);
> + bq2415x_set_voltage(cli, 0, 4200000);
> + bq2415x_set_current_limit(cli, 1800000, 1800000);

So it always charges with 1.8A? Shouldn't this be dependent on the
input source (e.g. 500mA from USB)? Also what's if no charger is
connected at all?

Apart from this I think those values should be exposed to sysfs
via /sys/class/power_supply.

-- Sebastian
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2011-12-06 03:21    [from the cache]
©2003-2011 Jasper Spaans