Messages in this thread Patch in this message | | | Date | Mon, 5 Dec 2011 09:37:26 -0800 | From | tip-bot for Thomas Meyer <> | Subject | [tip:x86/cleanups] x86: Use kmemdup() in copy_thread(), rather than duplicating its implementation |
| |
Commit-ID: cced40229993bb63238299e48a22e4c8d1e13181 Gitweb: http://git.kernel.org/tip/cced40229993bb63238299e48a22e4c8d1e13181 Author: Thomas Meyer <thomas@m3y3r.de> AuthorDate: Thu, 17 Nov 2011 23:43:40 +0100 Committer: Ingo Molnar <mingo@elte.hu> CommitDate: Mon, 5 Dec 2011 13:54:39 +0100
x86: Use kmemdup() in copy_thread(), rather than duplicating its implementation
The semantic patch that makes this change is available in scripts/coccinelle/api/memdup.cocci.
Signed-off-by: Thomas Meyer <thomas@m3y3r.de> Link: http://lkml.kernel.org/r/1321569820.1624.275.camel@localhost.localdomain Signed-off-by: Ingo Molnar <mingo@elte.hu> --- arch/x86/kernel/process_64.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c index 3bd7e6e..d2c1f62 100644 --- a/arch/x86/kernel/process_64.c +++ b/arch/x86/kernel/process_64.c @@ -293,13 +293,12 @@ int copy_thread(unsigned long clone_flags, unsigned long sp, memset(p->thread.ptrace_bps, 0, sizeof(p->thread.ptrace_bps)); if (unlikely(test_tsk_thread_flag(me, TIF_IO_BITMAP))) { - p->thread.io_bitmap_ptr = kmalloc(IO_BITMAP_BYTES, GFP_KERNEL); + p->thread.io_bitmap_ptr = kmemdup(me->thread.io_bitmap_ptr, + IO_BITMAP_BYTES, GFP_KERNEL); if (!p->thread.io_bitmap_ptr) { p->thread.io_bitmap_max = 0; return -ENOMEM; } - memcpy(p->thread.io_bitmap_ptr, me->thread.io_bitmap_ptr, - IO_BITMAP_BYTES); set_tsk_thread_flag(p, TIF_IO_BITMAP); }
| |