lkml.org 
[lkml]   [2011]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 10/22] ext4: Verify and calculate checksums for extent tree blocks
On Mon, Nov 28, 2011 at 03:27:25PM -0800, Darrick J. Wong wrote:
> /*
> + * This is the extent tail on-disk structure.
> + * All other extent structures are 12 bytes long. It turns out that
> + * block_size % 12 >= 4 for all valid block sizes (1k, 2k, 4k).

More generally, block_size % 12 is >= 4 for all powers of 2 greater
than 12 bytes. I'd probably remove (1k, 2k, 4k) because that might
scare people who might say, "hey! I'm using a 16k block size on my
HPC system running on a Power or Itanium box --- am I going to be OK?".
Valid block sizes go up to the page size of the hardware in question...

- Ted


\
 
 \ /
  Last update: 2011-12-05 17:43    [W:0.746 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site