lkml.org 
[lkml]   [2011]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 1/1] driver core: disable device's runtime pm during shutdown
Date


> > > So it is asleep when the new pm_runtime_disable() call is made, so it
> stays
> > > asleep, omap_i2c_xfer cannot wake it, the transfer doesn't happen and
> the
> > > system doesn't get powered off.
> > >
> > > So here is a device that should *not* have pm disabled at shutdown.
> > >
> > > So I feel this fix is a little too heavy-handed.
> >
> > Maybe the device's runtime PM should not be disabled if
> > there is no ->shutdown defined in its driver, how about the blew?
>
> Thanks, but that won't actually help.
>
> dev->bus->shutdown is i2c_device_shutdown so there is a shutdown method.
> However i2c_device_shutdown just finds the driver can calls
> driver->shutdown(), and that is the 'shutdown' that is NULL.
>
Then, i2c should be registered before than twl4030 as a platform device, since
twl4030 is an i2c device. Just let i2c shut down later than twl4030's.

> Thanks,
> NeilBrown
>
>
>



\
 
 \ /
  Last update: 2011-12-05 06:55    [W:0.068 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site