lkml.org 
[lkml]   [2011]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] dmaengine/ste_dma40: allow fixed physical channel
From
Date
On Wed, 2011-11-30 at 19:20 +0530, Narayanan G wrote:
> Allow logical channels to specify the physical channel they want to use.
> This is needed to avoid two peripherals operating on the same physical
> channel during some special use-cases. (like mmc and usb during a
> usb mass storage case).
>
> Signed-off-by: Rabin Vincent <rabin.vincent@stericsson.com>
> Signed-off-by: Narayanan G <narayanan.gopalakrishnan@stericsson.com>
Applied thanks.

There are some serious format issues with this driver.
Things like this are absolutely crazy, the fact that you are too deeply
nested itslf is a problem
@@ -1676,7 +1682,8 @@ static int d40_allocate_channel(struct d40_chan
*d40c)
> if (d40_alloc_mask_set(&phys[i],
> is_src,
> 0,
> - is_log))
> + is_log,
> + first_phy_user))
> goto found_phy;
> }
This could be made to look a lot cleaner...
Will add to my ever growing todo :D


--
~Vinod



\
 
 \ /
  Last update: 2011-12-05 05:03    [from the cache]
©2003-2011 Jasper Spaans