lkml.org 
[lkml]   [2011]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kvm: make vcpu life cycle separated from kvm instance
On 12/02/2011 08:26 AM, Liu Ping Fan wrote:
> From: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
>
> Currently, vcpu can be destructed only when kvm instance destroyed.
> Change this to vcpu's destruction taken when its refcnt is zero,
> and then vcpu MUST and CAN be destroyed before kvm's destroy.
>
>
> @@ -315,9 +315,17 @@ static void pit_do_work(struct work_struct *work)
> * LVT0 to NMI delivery. Other PIC interrupts are just sent to
> * VCPU0, and only if its LVT0 is in EXTINT mode.
> */
> - if (kvm->arch.vapics_in_nmi_mode > 0)
> - kvm_for_each_vcpu(i, vcpu, kvm)
> + if (kvm->arch.vapics_in_nmi_mode > 0) {
> + rcu_read_lock();
> + kvm_for_each_vcpu(i, cnt, vcpu, kvm) {
> + vcpu = kvm_get_vcpu(kvm, i);
> + if (vcpu == NULL)
> + continue;
> + cnt++;
> kvm_apic_nmi_wd_deliver(vcpu);
> + }
> + rcu_read_unlock();
> + }
> }
> }

This pattern keeps repeating, please fold it into kvm_for_each_vcpu().

--
error compiling committee.c: too many arguments to function



\
 
 \ /
  Last update: 2011-12-04 11:25    [W:0.347 / U:0.664 seconds]
©2003-2014 Jasper Spaans. hosted at Digital Ocean