lkml.org 
[lkml]   [2011]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 05/11] KVM: fix XSAVE bit scanning (now properly)
    From: Andre Przywara <andre.przywara@amd.com>

    commit 123108f1c1aafd51d6a5c79cc04d7999dd88a930 tried to fix KVMs
    XSAVE valid feature scanning, but it was wrong. It was not considering
    the sparse nature of this bitfield, instead reading values from
    uninitialized members of the entries array.
    This patch now separates subleaf indicies from KVM's array indicies
    and fills the entry before querying it's value.
    This fixes AVX support in KVM guests.

    Signed-off-by: Andre Przywara <andre.przywara@amd.com>
    Signed-off-by: Avi Kivity <avi@redhat.com>
    ---
    arch/x86/kvm/x86.c | 9 +++++----
    1 files changed, 5 insertions(+), 4 deletions(-)

    diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
    index f168c61..3567c76 100644
    --- a/arch/x86/kvm/x86.c
    +++ b/arch/x86/kvm/x86.c
    @@ -2419,16 +2419,17 @@ static void do_cpuid_ent(struct kvm_cpuid_entry2 *entry, u32 function,
    break;
    }
    case 0xd: {
    - int i;
    + int idx, i;

    entry->flags |= KVM_CPUID_FLAG_SIGNIFCANT_INDEX;
    - for (i = 1; *nent < maxnent && i < 64; ++i) {
    - if (entry[i].eax == 0 || !supported_xcr0_bit(i))
    + for (idx = 1, i = 1; *nent < maxnent && idx < 64; ++idx) {
    + do_cpuid_1_ent(&entry[i], function, idx);
    + if (entry[i].eax == 0 || !supported_xcr0_bit(idx))
    continue;
    - do_cpuid_1_ent(&entry[i], function, i);
    entry[i].flags |=
    KVM_CPUID_FLAG_SIGNIFCANT_INDEX;
    ++*nent;
    + ++i;
    }
    break;
    }
    --
    1.7.7.1

    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2011-12-04 20:05    [W:4.134 / U:0.444 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site