Messages in this thread | | | Date | Sun, 04 Dec 2011 10:36:42 +0100 | From | Lars-Peter Clausen <> | Subject | Re: [RFC] drivercore: Add helper macro for platform_driver boilerplate |
| |
On 12/04/2011 09:39 AM, Geert Uytterhoeven wrote: > On Wed, Oct 5, 2011 at 08:56, Greg KH <greg@kroah.com> wrote: >> On Tue, Oct 04, 2011 at 05:26:55PM -0600, Grant Likely wrote: >>> For simple modules that contain a single platform_driver without any >>> additional setup code then ends up being a block of duplicated >>> boilerplate. This patch adds a new macro, module_platform_driver(), >>> which replaces the module_init()/module_exit() registrations with >>> template functions. >>> >>> This patch also converts all the relevant spi drivers to use the new >>> macro. There are a lot of drivers in the tree that are using this >>> pattern and could be converted. >>> >>> It also fixes up some incorrect section annotations where I found >>> them. >>> >>> Signed-off-by: Grant Likely <grant.likely@secretlab.ca> >>> --- >>> >>> I think this is useful, and I like the diffstat that it produces. >>> What does everyone else think of this approach? I can do versions for >>> i2c_drivers and spi_drivers too. >>> >>> This is *not* tested very much. I'm circulating mostly for review for >>> now. >> >> The idea looks sane to me, I like the diffstat it ends up creating, nice >> job. > > I guess the macro can be extended (or wrapped around another one) to include > the bus type, so it applies to all bus types? > > It's a pity some use <bus>_register_driver(), while others use > <bus>_driver_register(), > so this needs some refactoring for unification. >
I've recently posted a patch series which extends the macro to take the bus's register/unregister function names so it can be used to build macros similar to module_platform_driver. [1] I used the register/unregister function names instead of the bus type, exactly because there is no common naming convention for these. So you still need to define the macro for a new bus type, but it should be a two-liner.
- Lars
[1] https://lkml.org/lkml/2011/11/16/77
| |