Messages in this thread Patch in this message | | | Date | Fri, 30 Dec 2011 22:50:24 +0100 | From | Francois Romieu <> | Subject | Re: [PATCH 1/1] via-rhine: Fix hanging with high CPU load on low-end broads. |
| |
Bjarke Istrup Pedersen <gurligebis@gentoo.org> : [...] > Just applied it to HEAD of net-next, and got the following compiler warning: > drivers/net/ethernet/via/via-rhine.c:2182:13: warning: > 'rhine_task_enable' defined but not used
You are running with CONFIG_PM disabled and a down / up loop will not work. The patch below should hide the latter, at least as long as the relevant workqueue does not stall for too long... Extra cancel_work in task_enable could work too but it will look strange.
> Just so you know that too :)
Thanks for testing.
diff --git a/drivers/net/ethernet/via/via-rhine.c b/drivers/net/ethernet/via/via-rhine.c index c57e1da..89ced1b 100644 --- a/drivers/net/ethernet/via/via-rhine.c +++ b/drivers/net/ethernet/via/via-rhine.c @@ -1536,6 +1536,7 @@ static int rhine_open(struct net_device *dev) alloc_rbufs(dev); alloc_tbufs(dev); rhine_chip_reset(dev); + rhine_task_enable(rp); init_registers(dev); if (debug > 2) netdev_dbg(dev, "%s() Done - status %04x MII status: %04x\n", -- Ueimor
| |