Messages in this thread | | | Date | Tue, 27 Dec 2011 21:21:18 +0800 | Subject | Re: [PATCH] mm: hugetlb: add might_sleep() for gigantic page | From | Hillf Danton <> |
| |
On Tue, Dec 27, 2011 at 8:59 PM, Michal Hocko <mhocko@suse.cz> wrote: > On Fri 23-12-11 21:41:08, Hillf Danton wrote: >> From: Hillf Danton <dhillf@gmail.com> >> Subject: [PATCH] mm: hugetlb: add might_sleep() for gigantic page >> >> Like the case of huge page, might_sleep() is added for gigantic page, then >> both are treated in same way. > > Why do we need to call might_sleep here? There is cond_resched in the > loop... >
IIUC it is the reason to add... and the comment says
/** * might_sleep - annotation for functions that can sleep * * this macro will print a stack trace if it is executed in an atomic * context (spinlock, irq-handler, ...). * * This is a useful debugging help to be able to catch problems early and not * be bitten later when the calling function happens to sleep when it is not * supposed to. */
Thanks Hillf
| |