lkml.org 
[lkml]   [2011]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Fwd: [patch] intel_idle: Delete meaningless local_irq_disable() call in intel_idle.c.]
From
Date
On Tue, 2011-12-27 at 16:10 -0800, Andrew Morton wrote:
> On Mon, 26 Dec 2011 09:28:20 +0800
> Yanmin Zhang <yanmin_zhang@linux.intel.com> wrote:
>
> > Andrew,
> >
> > Would you like to accept the patch into your testing tree?
>
> hm, that's three indel_idle patches which I have now. Someone wake up
> lenb!
>
> > intel_idle.c is a bit misleading in a sense that local_irq_disable,it
>

> I'd suggest adding this as well:
Agree. It'll be clearer.

>
> --- a/drivers/idle/intel_idle.c~drivers-idle-intel_idlec-remove-redundant-local_irq_disable-call-fix
> +++ a/drivers/idle/intel_idle.c
> @@ -232,6 +232,7 @@ static int get_driver_data(int cstate)
> * @drv: cpuidle driver
> * @index: index of cpuidle state
> *
> + * Must be called under local_irq_disable().
> */
> static int intel_idle(struct cpuidle_device *dev,
> struct cpuidle_driver *drv, int index)




\
 
 \ /
  Last update: 2011-12-28 01:31    [W:0.057 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site