lkml.org 
[lkml]   [2011]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5/6] memcg: fix broken boolen expression
    On Sat 24-12-11 05:00:18, Kirill A. Shutemov wrote:
    > From: "Kirill A. Shutemov" <kirill@shutemov.name>
    >
    > action != CPU_DEAD || action != CPU_DEAD_FROZEN is always true.
    >
    > Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>

    Acked-by: Michal Hocko <mhocko@suse.cz>

    Thanks!

    > ---
    > mm/memcontrol.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/mm/memcontrol.c b/mm/memcontrol.c
    > index b27ce0f..3833a7b 100644
    > --- a/mm/memcontrol.c
    > +++ b/mm/memcontrol.c
    > @@ -2100,7 +2100,7 @@ static int __cpuinit memcg_cpu_hotplug_callback(struct notifier_block *nb,
    > return NOTIFY_OK;
    > }
    >
    > - if ((action != CPU_DEAD) || action != CPU_DEAD_FROZEN)
    > + if (action != CPU_DEAD && action != CPU_DEAD_FROZEN)
    > return NOTIFY_OK;
    >
    > for_each_mem_cgroup(iter)
    > --
    > 1.7.7.3
    >

    --
    Michal Hocko
    SUSE Labs
    SUSE LINUX s.r.o.
    Lihovarska 1060/12
    190 00 Praha 9
    Czech Republic


    \
     
     \ /
      Last update: 2011-12-27 15:19    [W:0.020 / U:32.664 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site