[lkml]   [2011]   [Dec]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 1/9] drivers/mfd/88pm860x-i2c.c: introduce missing kfree
    On Mon, Dec 26, 2011 at 01:18:54PM +0100, Julia Lawall wrote:
    > On Mon, 26 Dec 2011, Mark Brown wrote:

    > >With this and probably a bunch of the other corrections in this series a
    > >conversion to devm_kazlloc() would be a more complete fix as it prevents
    > >people introducing similar missing cleanup paths in future. Not sure if
    > >spatch can generate that automatically though...

    > I saw a patch for that recently, and looked into it a little bit,
    > but I wasn't sure what should be done. What are the criteria for
    > using devm_kzalloc?

    It's good for any allocation that lasts for the lifetime of the device -
    most driver data allocated in probe() fits well, for example.

     \ /
      Last update: 2011-12-26 13:23    [W:0.018 / U:36.892 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site