lkml.org 
[lkml]   [2011]   [Dec]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cgroup: move a check to parse_cgroupfs_options()
Tejun Heo wrote:
> Hello,
>
> On Thu, Dec 22, 2011 at 7:40 PM, Li Zefan <lizf@cn.fujitsu.com> wrote:
>>> And where did this one go?
>>
>> The other one I removed sets opts->new_root to NULL, and this one detects
>> the NULL ptr:
>>
>> if (!opts->subsys_bits && !opts->none)
>> return NULL;
>> ...
>> opts->new_root = NULL;
>> ...
>> if (!opts->new_root)
>> return -EINVAL;
>>
>> shortcut to:
>>
>> if (!opts->subsys_bits && !opts->none)
>> return -EINVAL;
>
> Thanks for the explanation. Maybe explaining it briefly in the commit
> message would be nice?
>

I recalled why we have this check in this place, that is to allow mounting
by hierarchy name, but it has been broken for a long time. I'll send a
fix with detailed changelog.


\
 
 \ /
  Last update: 2011-12-27 02:49    [W:0.043 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site