lkml.org 
[lkml]   [2011]   [Dec]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv2] Regulator: Add Anatop regulator driver
    On Thu, Dec 22, 2011 at 11:33:38AM +0000, Mark Brown wrote:
    > On Wed, Dec 21, 2011 at 05:03:31PM +0800, Ying-Chun Liu (PaulLiu) wrote:

    > > + if (anatop_reg->rdata->control_reg) {
    > > + val = anatop_reg->rdata->min_bit_val +
    > > + (uv - reg->constraints->min_uV) / 25000;

    > You're not checking that the resulting voltage matches the constraints
    > or updating selector.

    Also on re-reading this looks *very* broken - you're using the
    constraints value in your set_voltage() operation. The runtime
    constraints a system has should have *no* impact on the way you ask for
    a specific voltage from the regulator.


    \
     
     \ /
      Last update: 2011-12-24 13:39    [W:2.229 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site