Messages in this thread | | | Date | Fri, 23 Dec 2011 14:52:40 -0800 | Subject | Re: [PATCH] cgroup: move a check to parse_cgroupfs_options() | From | Tejun Heo <> |
| |
Hello,
On Thu, Dec 22, 2011 at 7:40 PM, Li Zefan <lizf@cn.fujitsu.com> wrote: >> And where did this one go? > > The other one I removed sets opts->new_root to NULL, and this one detects > the NULL ptr: > > if (!opts->subsys_bits && !opts->none) > return NULL; > ... > opts->new_root = NULL; > ... > if (!opts->new_root) > return -EINVAL; > > shortcut to: > > if (!opts->subsys_bits && !opts->none) > return -EINVAL;
Thanks for the explanation. Maybe explaining it briefly in the commit message would be nice?
-- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |