lkml.org 
[lkml]   [2011]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Print PCI device in power management warning.
On Fri, 23 Dec 2011 13:16:26 -0500
Dave Jones <davej@redhat.com> wrote:

> When the WARN_ON in pci_has_legacy_pm_support() triggers, we get
> users filing backtraces, but it's not obvious which driver is
> triggering the trace. This adds a printk before the BUG.
> This still isn't perfect (automated tools like abrt will still miss it)
> but we can at least ask the user to look through their dmesg when
> we get these traces reported.
>
> Signed-off-by: Dave Jones <davej@redhat.com>

NAK

The old code did a WARN() the new code BUG() which in practice means in
many cases the user will get a crash and hang at boot and not even be
able to catch the trap.

At the very least your changelog should warn people it changes from
WARN_ON noise to system crash and burn.

Alan


\
 
 \ /
  Last update: 2011-12-23 21:47    [from the cache]
©2003-2011 Jasper Spaans