lkml.org 
[lkml]   [2011]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectPrint PCI device in power management warning.
When the WARN_ON in pci_has_legacy_pm_support() triggers, we get
users filing backtraces, but it's not obvious which driver is
triggering the trace. This adds a printk before the BUG.
This still isn't perfect (automated tools like abrt will still miss it)
but we can at least ask the user to look through their dmesg when
we get these traces reported.

Signed-off-by: Dave Jones <davej@redhat.com>

diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c
index 12d1e81..b638244 100644
--- a/drivers/pci/pci-driver.c
+++ b/drivers/pci/pci-driver.c
@@ -604,7 +604,12 @@ static bool pci_has_legacy_pm_support(struct pci_dev *pci_dev)
* supported as well. Drivers are supposed to support either the
* former, or the latter, but not both at the same time.
*/
- WARN_ON(ret && drv->driver.pm);
+ if (ret && drv->driver.pm) {
+ printk(KERN_WARNING "pci: %s has both legacy and new PM support.\n",
+ drv->name);
+ BUG();
+ }
+

return ret;
}

\
 
 \ /
  Last update: 2011-12-23 19:19    [W:0.032 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site