lkml.org 
[lkml]   [2011]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:perf/core] perf symbols: Get rid of duplicated snprintf()
    Commit-ID:  2b600f9578852d12af59420011e3dadfaa58b043
    Gitweb: http://git.kernel.org/tip/2b600f9578852d12af59420011e3dadfaa58b043
    Author: Namhyung Kim <namhyung@gmail.com>
    AuthorDate: Tue, 13 Dec 2011 00:16:51 +0900
    Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
    CommitDate: Tue, 20 Dec 2011 13:34:52 -0200

    perf symbols: Get rid of duplicated snprintf()

    The 'path' variable is set on a upper line, don't need to do it again.

    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Link: http://lkml.kernel.org/r/1323703017-6060-3-git-send-email-namhyung@gmail.com
    Signed-off-by: Namhyung Kim <namhyung@gmail.com>
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/util/symbol.c | 7 +------
    1 files changed, 1 insertions(+), 6 deletions(-)

    diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
    index 632b50c..e54b13d 100644
    --- a/tools/perf/util/symbol.c
    +++ b/tools/perf/util/symbol.c
    @@ -1757,7 +1757,7 @@ static int map_groups__set_modules_path_dir(struct map_groups *mg,
    struct stat st;

    /*sshfs might return bad dent->d_type, so we have to stat*/
    - sprintf(path, "%s/%s", dir_name, dent->d_name);
    + snprintf(path, sizeof(path), "%s/%s", dir_name, dent->d_name);
    if (stat(path, &st))
    continue;

    @@ -1766,8 +1766,6 @@ static int map_groups__set_modules_path_dir(struct map_groups *mg,
    !strcmp(dent->d_name, ".."))
    continue;

    - snprintf(path, sizeof(path), "%s/%s",
    - dir_name, dent->d_name);
    ret = map_groups__set_modules_path_dir(mg, path);
    if (ret < 0)
    goto out;
    @@ -1788,9 +1786,6 @@ static int map_groups__set_modules_path_dir(struct map_groups *mg,
    if (map == NULL)
    continue;

    - snprintf(path, sizeof(path), "%s/%s",
    - dir_name, dent->d_name);
    -
    long_name = strdup(path);
    if (long_name == NULL) {
    ret = -1;

    \
     
     \ /
      Last update: 2011-12-21 09:47    [W:0.023 / U:61.508 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site